Revert "CHANGE: XRI test ignored as it is causing issues in the CI. I…#2399
Merged
josepmariapujol-unity merged 3 commits intodevelopfrom Apr 7, 2026
Merged
Revert "CHANGE: XRI test ignored as it is causing issues in the CI. I…#2399josepmariapujol-unity merged 3 commits intodevelopfrom
josepmariapujol-unity merged 3 commits intodevelopfrom
Conversation
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2399 +/- ##
===========================================
+ Coverage 77.92% 78.11% +0.19%
===========================================
Files 482 483 +1
Lines 97755 98784 +1029
===========================================
+ Hits 76175 77170 +995
- Misses 21580 21614 +34 Flags with carried forward coverage won't be shown. Click here to find out more.
|
chris-massie
approved these changes
Apr 2, 2026
Collaborator
chris-massie
left a comment
chris-massie
left a comment
There was a problem hiding this comment.
All tests pass now with the latest XRI version.
Fixing the typo in the method name would be nice before merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t should be re-enabled once resolved (#2390)"
This reverts commit 0bb75c4.
In addition, this PR addresses the typo on the method.
Before:
XRIPackageTests.AdddingLatestXRIPackageThrowsNoErrorsAfter:
XRIPackageTests.AddingLatestXRIPackageThrowsNoErrorsPass:
https://unity-ci.cds.internal.unity3d.com/job/66074078/logs 🟢